Simpl Payments Icon

[mrinalika-ghosh]

Why are you adding this icons?

I'm adding/updating this icon(s) because Simpl Payments offers Pay Later & Pay in 3 solutions to customers in India (https://getsimpl.com/). This is a payment method offered on Shopify via Simpl Payments App today

Help us identify yourself

• [x] I'm working/collaborating with the brand directly and they have provided the icons.
• [ ] I'm associated with the brand and I've read all the brand icon’s guidelines.
• [ ] I'm an individual and I've read all the brand icon’s guidelines. Link to the brand guidelines:

  Checklist to add new icons

• [x] All icons have a corresponding entry in db/payment_icons.yml
• [x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
• [x] I have optimized the icon with SVGO
• [x] I am confident that all icons are clear and easy to read/understand
• [ ] I have provided a link to the brand icon’s brand guidelines whenever possible.
• [x] I have attached a screenshot comparison with the example icon provided in guidelines
• [x] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger. If this pull request is not adding new icons, you can remove this checklist.

  Attach a screenshot of the icon along side the example Visa icon

  

  Tips how to create a screenshot

  We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

  

  <!-- Change background color if needed to showcase your icon better -->
  <style> body { background: white; } </style>
  <!-- DO NOT DELETE EXAMPLE -->
  <svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>
  <!-- TODO: insert your icon here -->
  <YOUR SVG CODE>
  <br>
  <!-- TODO: insert your icon here -->
  <YOUR SVG CODE>
  </br

  If the icons are intended for use by Shopify, please provide the following info:

  Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) Shopify India Team as a Payment Partner What's the expected date of this change to deploy on Shopify?

[hellicarusprime]

Hi @Mrinalika Is it only the Simpl logo you're trying to add? If that's the case you don't need to upload icons for the other 3. The icon is also the incorrect size. Please refer to our for more information.

[mrinalika-ghosh]

Hi Michael, I have updated the code as requested. Can you please check again?

[hellicarusprime]

Hi @mrinalika-ghosh, the icon still isn't the right size, but it looks like I accidentally missed the link to our contributing guidelines in my last message. Refer to these to ensure your icon is correct.

[mrinalika-ghosh]

Hi @hellicarusprime, We have updated again the file. Can you please check the latest *.svg file now.

[hellicarusprime]

Hi @Mrinalika, the size of the icon you added is 40 x 26—it should be 38 x 24. The visible border should be included.

[mrinalika-ghosh]

@hellicarusprime - Updated

[hellicarusprime]

Hi @mrinalika-ghosh, there are still a couple of issues with the icon. Please refer to our contributing guidelines to address these.

Issues:

• The name of the SVG must be the same as the name entered in db/payment_icons.yml
• The border must have a 2px radius (outside stroke)

[mrinalika-ghosh]

@hellicarusprime Apologies for the back and forth. Hope this time we were able to make the required changes.

[hellicarusprime]

The icon looks good now @mrinalika-ghosh, but you have some conflicts that need to be resolved.

[mrinalika-ghosh]

Hey! Thanks, @hellicarusprime - are there any other tasks for me to complete? Also, when will this show up in the Shopify Payment Icons as an option?

[mrinalika-ghosh]

@hellicarusprime Just wanted to check since the test has failed. Are we supposed to make any changes?

[hellicarusprime]

@hellicarusprime Just wanted to check since the test has failed. Are we supposed to make any changes?

Cc: @adeniyiao

[mrinalika-ghosh]

Have resolved the conflicts again @hellicarusprime Let me know in case we are suppose to update anything else from our end

[mrinalika-ghosh]

@Lovedanihonjin : Can you please check once now?

[mrinalika-ghosh]

Resolved the above error

[mrinalika-ghosh]

@Lovedanihonjin : Let me know if still I am missing anything in my latest commit?

[mrinalika-ghosh]

@Lovedanihonjin : Have made the changes again. Let me know if anything else needed from my end.