add TipTop payment method icon

ryantiptop commented 3 months ago

Why are you adding this icons?

I'm adding this icon because TipTop is a new payment method for Shopify stores and we want this icon featured when customers choose to pay with TipTop

Help us identify yourself

[ ] I'm working/collaborating with the brand directly and they have provided the icons.
[x] I'm associated with the brand and I've read all the brand icon’s guidelines.
[ ] I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines: N/A - see tiptop.com for information about our product. We also have an app in the iOS App Store.

Checklist to add new icons

[x] All icons have a corresponding entry in db/payment_icons.yml
[x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
[x] I have optimized the icon with SVGO
[x] I am confident that all icons are clear and easy to read/understand
[x] I have provided a link to the brand icon’s brand guidelines whenever possible.
[x] I have attached a screenshot comparison with the example icon provided in guidelines
[x] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

Meghan Donaldson

What's the expected date of this change to deploy on Shopify?

TipTop payments app was submitted for review on April 3, 2024. We are ready to go live once approved.

hellicarusprime commented 3 months ago

Hi @ryantiptop—could you please add a visible border to the icon? See our contributing guidelines.

ryantiptop commented 3 months ago

Hi @hellicarusprime. I added a border according to the guidelines and attached an updated screenshot. Ready for review again! Thanks.

hellicarusprime commented 3 months ago

Hi @ryantiptop—you're border radius isn't correct.

The border must have a 2px radius

ryantiptop commented 3 months ago

@hellicarusprime the outer border does have a 2px radius. Here's a screenshot from Figma.

hellicarusprime commented 3 months ago

Hey @ryantiptop, in the example you shared, it looks like you're using an inside stroke.

ryantiptop commented 2 months ago

@hellicarusprime thank you for the clarification. I updated our icon with the correct outer stroke and provided a new screenshot. thank you.

ryantiptop commented 2 months ago

Hi @Lovedanihonjin. I think the new changes should satisfy your request. thank you.

ryantiptop commented 2 months ago

Hi, @hellicarusprime and @Lovedanihonjin. This is ready for re-review. Thank you!

ryantiptop commented 2 months ago

Hi, @hellicarusprime and @Lovedanihonjin, kindly bumping this PR to get it reviewed again. Our payment app was approved by Shopify today.

activemerchant / payment_icons