Closed kevinverschoor closed 2 months ago
Requested changes to the SVG file and yml.
Please expand the stroke for the SVG - this is what it looks like when I pull it into our Figma library.
I have fixed the SVG for Figma.
Any reason why the "i" in in3 is lowercased in the label?
The brandname itself is "in3" with only lowercase letters, thus we've also applied this to the label. https://payin3.eu/en/ideal-in3/for-merchants/
Thanks - New changes look great! Any reason you are using a #D0D0D0 background color on the SVG? Is it part of your brand guidelines? Thank you!
That is correct it is one of the iDEAL in3 brand colours.
I saw there were merge conflicts so I resolved them right away.
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) Adeniyi Adeyemi
What's the expected date of this change to deploy on Shopify? We would like to update our in3 payment method with this new logo as soon as possible.