search

activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
142 stars 409 forks source link

Float Payments Icon not displaying correctly #1178

Closed BradleyGoulding closed 2 weeks ago

BradleyGoulding commented 2 months ago

We updated the icon for Float Payments approximately 3 weeks ago with PR #1166, however the icon when added to our payments app does not display at all.

Screenshot 2024-05-06 at 17 10 49

however the file displays correctly in github for example

Screenshot 2024-05-06 at 17 10 58

If i inspect the element that is not displaying in the first screenshot, I get the url here https://cdn.shopify.com/shopifycloud/partners-web-platform/partners-dashboard/52b622c5c523a41ae25d.svg

It appears to be loading correctly and with the correct content type.

I am not sure what the way forward to fix this is.

BradleyGoulding commented 2 months ago

Any feedback available?

adeniyiao commented 1 month ago

Hi @BradleyGoulding , Looks like the SVG is missing some attributes noticeably xmlns="http://www.w3.org/2000/svg", so you will need to submit PR with an updated icon with the attributes as per this template

BradleyGoulding commented 1 month ago

Hi @adeniyiao, thank you for your feedback. I have made the required change and opened the PR #1193

adeniyiao commented 2 weeks ago

Closing as icon is showing correctly now

image