Closed ALibrenjak-Corvuspay closed 4 months ago
Improved version of image is uploaded. Conflicts are resolved.
Hi @ALibrenjak-Corvuspay ,
Your PR shows more files changes are being made than required. Could you please rebase this PR against activemerchant:master or preferably closing this PR and submitting a new PR as there are too many commits to follow through the changes. You should only be adding your new icon and adding it to the db/payment_icons.yml
only
Thanks
Hi @adeniyiao, New pull request is https://github.com/activemerchant/payment_icons/pull/1185.
Why are you adding this icons?
I'm adding this icon because CorvusPay's payment app needs to add DinaCard as payment method according to ticket 44582605. https://dinacard.nbs.rs/english/index.html
Help us identify yourself
Link to the brand guidelines: -Not available
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) When we (CorvusPay) required about the possibility of adding DinaCard icon in payment method, we got answer from Miguel Q that we need to add icon here (ticket 44582605).
What's the expected date of this change to deploy on Shopify? As soon as it is possible.