Closed ALibrenjak-Corvuspay closed 1 month ago
Hey @ALibrenjak-Corvuspay
Could you fixed this issue with the SVG. Thanks
{:message=>"The 'dinacard' SVG file does not have the appropriate <title> value"}.
Expected: "DinaCard"
Actual: "Dinacard"
@adeniyiao
Title is changed.
Hi @ALibrenjak-Corvuspay ,
Could please address the test failure below. Thanks
{:message=>"The 'path14' ID should be pi-dinacard-path14 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "path14".
Hi @adeniyiao, prefix was added
I'm adding this icon because CorvusPay's payment app needs to add DinaCard as payment method according to ticket 44582605. https://dinacard.nbs.rs/english/index.html
Help us identify yourself [ ✓ ] I'm working/collaborating with the brand directly and they have provided the icons. I'm associated with the brand and I've read all the brand icon’s guidelines. I'm an individual and I've read all the brand icon’s guidelines. Link to the brand guidelines: -Not available
Checklist to add new icons [ ✓ ] All icons have a corresponding entry in db/payment_icons.yml [ ✓ ] I have followed the icon guidelines detailed in the CONTRIBUTING.md file [ ✓ ] I have optimized the icon with SVGO [ ✓ ] I am confident that all icons are clear and easy to read/understand [ ✓ ] I have provided a link to the brand icon’s brand guidelines whenever possible. [ ✓ ] I have attached a screenshot comparison with the example icon provided in guidelines [ ✓ ] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger. If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon dina visa
Tips how to create a screenshot We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.