activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
142 stars 409 forks source link

Add dinacard.svg to icons #1185

Closed ALibrenjak-Corvuspay closed 1 month ago

ALibrenjak-Corvuspay commented 2 months ago

I'm adding this icon because CorvusPay's payment app needs to add DinaCard as payment method according to ticket 44582605. https://dinacard.nbs.rs/english/index.html

Help us identify yourself [ ✓ ] I'm working/collaborating with the brand directly and they have provided the icons. I'm associated with the brand and I've read all the brand icon’s guidelines. I'm an individual and I've read all the brand icon’s guidelines. Link to the brand guidelines: -Not available

Checklist to add new icons [ ✓ ] All icons have a corresponding entry in db/payment_icons.yml [ ✓ ] I have followed the icon guidelines detailed in the CONTRIBUTING.md file [ ✓ ] I have optimized the icon with SVGO [ ✓ ] I am confident that all icons are clear and easy to read/understand [ ✓ ] I have provided a link to the brand icon’s brand guidelines whenever possible. [ ✓ ] I have attached a screenshot comparison with the example icon provided in guidelines [ ✓ ] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger. If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon dina visa

Tips how to create a screenshot We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

Visa Dinacard
Dinacard
If the icons are intended for use by Shopify, please provide the following info: Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) When we (CorvusPay) required about the possibility of adding DinaCard icon in payment method, we got answer from Miguel Q that we need to add icon here (ticket 44582605). What's the expected date of this change to deploy on Shopify? As soon as it is possible
adeniyiao commented 2 months ago

Hey @ALibrenjak-Corvuspay

Could you fixed this issue with the SVG. Thanks

{:message=>"The 'dinacard' SVG file does not have the appropriate <title> value"}.
Expected: "DinaCard"
  Actual: "Dinacard"
ALibrenjak-Corvuspay commented 2 months ago

@adeniyiao

Title is changed.

adeniyiao commented 1 month ago

Hi @ALibrenjak-Corvuspay ,

Could please address the test failure below. Thanks

{:message=>"The 'path14' ID should be pi-dinacard-path14 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "path14".
ALibrenjak-Corvuspay commented 1 month ago

Hi @adeniyiao, prefix was added