Open gomonke opened 1 month ago
adeniyiao
commented
1 month ago Hi @gomonke ,
Kindly address the test failure below
{:message=>"The 'sistecredito' SVG file does not have the appropriate <title> value"}.
Expected: "Sistecredito"
Actual: "sistecredito"
gomonke
commented
1 month ago Hi @gomonke ,
Kindly address the test failure below
{:message=>"The 'sistecredito' SVG file does not have the appropriate <title> value"}. Expected: "Sistecredito" Actual: "sistecredito"
Hi @adeniyiao , title is changed
Why are you adding this icons?
I'm adding/updating this icon(s) because we have the application approved and listed at https://apps.shopify.com/sistecredito-app. We need to update the payment method icon
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.ymlIf this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) @gomonke
What's the expected date of this change to deploy on Shopify? 04/15/2024