Closed matthaywardwebdesign closed 1 month ago
@matthaywardwebdesign Are you able to look into the error which is being flagged: Expected image tag to contain base64 encoded PNG, found 'data:image/jpeg;base64,/9j/4AAQSkZJRgABAgEAlgCW...'
Also, it looks like you may need to re-base
Hi @matthaywardwebdesign , this PR failed CI test with the error below. Kindly address the issue. Thanks
PaymentIconTest#test_Payment_icon_SVGs_are_a_single_line [test/unit/payment_icon_test.rb:127]:
The 'payright' SVG file should contain a single line of markup, optionally terminated by an empty line
Hey @adeniyiao That's been resolved.
Why are you adding this icons?
I'm adding/updating this icon(s) because this is a new payment gateway for Shopify - approved under Partner account Payright.
Help us identify yourself
Link to the brand guidelines: Not available
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
They are intended for use by Shopify - please see ticket 48133790
What's the expected date of this change to deploy on Shopify?
As soon as possible.