Open kevin-bijoux-fintech opened 3 months ago
Hello @samuelmartingc (and other Shopify maintainers),
I see you recently created and merged a PR to add/update icons, cf. #1226.
This PR (#1207), as well as other PRs like #1216, #1218, #1224, and #1211, have also been approved. Could you please create a PR to make them available? Or at least, could you provide us with an estimated publish date?
Thanks 🙏
Hello @Lydia-shan-git, I see you are recently active on PR. Would it be possible to have your feedback/approve to merge/deploy this PR? Thanks a lot
Why are you adding this icons?
I'm updating the Cartes Bancaires icon because since July 17th, the graphic charter of Cartes Bancaires has changed, cf. https://www.cartes-bancaires.com/wp-content/uploads/2024/07/charte_graphique_logo_CB_2024.pdf.
Help us identify yourself
Link to the brand guidelines: https://www.cartes-bancaires.com/wp-content/uploads/2024/07/charte_graphique_logo_CB_2024.pdf
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify? ASAP, since the guideline is now effective.