Open pagopar-dev opened 4 months ago
Hi @pagopar-dev ,
Kindly address the test failure as stated below
Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:81]:
{:message=>"The 'aqui-pago' SVG file does not have the appropriate 'id' value on the <title> tag"}.
Expected: "pi-aqui-pago"
Actual: "pi-aquipago"
Also just a quick observation, icon name should be lowercase alpha characters for the name in the yml and SVG as well.
Hi @pagopar-dev, are you able to complete the required change this week? We will be running another release cycle soon
@pagopar-dev are you able to make the corrections today? If not, it will be at least another month before we can attempt to merge these changes in Prod.
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) Following the official Shopify documentation, we found this repository with the steps to follow to add icons to our payment gateway, we are Pagopar, a Shopify partner, on Github (@pagopar-dev)
What's the expected date of this change to deploy on Shopify? As soon as it is possible