Open Candres1019 opened 3 weeks ago
Hi @Candres1019,
Kindly address the test failure as seen below
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]:
{:message=>"The 'Capa_1' ID should be pi-efecty-Capa_1 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "Capa_1".
Hi @adeniyiao ,
Thanks for the comments, i just made the changes to add the pi preffix in the ids
hello. i'm not very experienced with pull requests, so i'm wondering if this will be an issue: i have a previous open pull request updating the Visa icon as well: #1210.
i also have (i believe) slightly better icons for Nequi and Efecty ready, but i didn't submit because i wasn't sure whether they'd be approved based on the Shopify Partners disclaimer. how could i propose those, without affecting this pull request?
Why are you adding this icons?
Added new icons for Nequi, Efecty, and Yape—Colombian and Peruvian payment methods, respectively. These icons will be used by PayU. Also, corrected inconsistencies and defects in the Visa logo, ensuring uniformity in letter colors and clarity.
Help us identify yourself
Link to the brand guidelines:
Colombia:
Nequi - https://www.nequi.com.co/ Efecty - https://www.efecty.com.co/web/
Peru
Yape - https://www.yape.com.pe/
Global
Visa - https://www.merchantsignage.visa.com/brand_guidelines
Checklist to add new icons
db/payment_icons.yml
Attach a screenshot of the icon along side the example Visa icon
What's the expected date of this change to deploy on Shopify? < 3 Days