Closed samuelmartingc closed 2 weeks ago
Hi @nickagin, I saw you approved similar PRs, may you review this one? https://github.com/activemerchant/payment_icons/pull/1219
TY
Hi @samuelmartingc ,
PR fails with the error below
Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]:
{:message=>"The 'mask0_7183_23536' ID should be pi-authorize_net-mask0_7183_23536 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "mask0_7183_23536".
Also just a quick observation, icon name should be lowercase alpha characters only so authorize_net
for the name in the yml and SVG as well.
Why are you adding this icons?
I'm adding/updating this icon(s) because they are requested by UX in our current project to support the existing payment providers in legacy subscriptions.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
Stripe
Braintree
Adyen
Authorize Net
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
@nickagin
What's the expected date of this change to deploy on Shopify? ASAP