Closed SyedAzeemAbbas closed 3 hours ago
Hi @SyedAzeemAbbas , are you able to correct the following issue in the SVG?
Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:78]: {:message=>"The 'jazzcash' SVG file does not have the appropriate
sure why not i am resolving this issue
hi @dannye0231 I have resolved SVG issue
Hi @SyedAzeemAbbas , are you able to check the other error that is now showing up?
Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'textGradient' ID should be pi-jazzcash-textGradient (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "textGradient".
yes i have gone through it and resolved this issue
On Mon, Sep 30, 2024 at 11:43 PM Danny Elisha @.***> wrote:
Hi @SyedAzeemAbbas https://github.com/SyedAzeemAbbas , are you able to check the other error that is now showing up?
Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'textGradient' ID should be pi-jazzcash-textGradient (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "textGradient".
— Reply to this email directly, view it on GitHub https://github.com/activemerchant/payment_icons/pull/1231#issuecomment-2383914674, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW7JJLSV5HPFBXESTLXS5TZZGLVFAVCNFSM6AAAAABPA4OSLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHEYTINRXGQ . You are receiving this because you were mentioned.Message ID: @.***>
-- Syed Azeem Abbas +92 3453677361
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?