activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
149 stars 436 forks source link

jazz cash wallet payment icon #1231

Closed SyedAzeemAbbas closed 3 hours ago

SyedAzeemAbbas commented 1 month ago

Why are you adding this icons?

I'm adding/updating this icon(s) because ..

Help us identify yourself

Link to the brand guidelines:

Checklist to add new icons

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: white; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 38 24" width="38" height="24" role="img" aria-labelledby="pi-jazzcash"><title id="pi-jazzcash">Jazz Cash Logo</title><path fill="#000" d="M0 0h38v24H0z"/><rect width="38" height="24" fill="none" stroke="#000" stroke-opacity=".07" stroke-width="1" rx="2"/><circle cx="11" cy="12" r="7" fill="#9c0001"/><defs><linearGradient id="textGradient" x1="0%" y1="0%" x2="0%" y2="100%"><stop offset="0%" stop-color="#fac409" stop-opacity="1"/><stop offset="50%" stop-color="#f6df14" stop-opacity="1"/><stop offset="100%" stop-color="#fac807" stop-opacity="1"/></linearGradient></defs><text x="2" y="15" font-family="Arial" font-size="8" fill="url(#textGradient)" font-weight="bold">Jazz</text><text x="19" y="15" font-family="Arial" font-size="7" fill="url(#textGradient)" stroke="#9c0001" stroke-width=".2" font-weight="bold">Cash</text></svg>

<br>
<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 38 24" width="38" height="24" role="img" aria-labelledby="pi-jazzcash"><title id="pi-jazzcash">Jazz Cash Logo</title><path fill="#000" d="M0 0h38v24H0z"/><rect width="38" height="24" fill="none" stroke="#000" stroke-opacity=".07" stroke-width="1" rx="2"/><circle cx="11" cy="12" r="7" fill="#9c0001"/><defs><linearGradient id="textGradient" x1="0%" y1="0%" x2="0%" y2="100%"><stop offset="0%" stop-color="#fac409" stop-opacity="1"/><stop offset="50%" stop-color="#f6df14" stop-opacity="1"/><stop offset="100%" stop-color="#fac807" stop-opacity="1"/></linearGradient></defs><text x="2" y="15" font-family="Arial" font-size="8" fill="url(#textGradient)" font-weight="bold">Jazz</text><text x="19" y="15" font-family="Arial" font-size="7" fill="url(#textGradient)" stroke="#9c0001" stroke-width=".2" font-weight="bold">Cash</text></svg>
</br

Screenshot 2024-09-29 at 12 53 22 AM

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

SyedAzeemAbbas commented 1 month ago

Screenshot 2024-09-29 at 12 53 22 AM

dannye0231 commented 1 month ago

Hi @SyedAzeemAbbas , are you able to correct the following issue in the SVG?

Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:78]: {:message=>"The 'jazzcash' SVG file does not have the appropriate value"}. Expected: "JazzCash" Actual: "Jazz Cash Logo"</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SyedAzeemAbbas"><img src="https://avatars.githubusercontent.com/u/11400357?v=4" />SyedAzeemAbbas</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <p>sure why not i am resolving this issue</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SyedAzeemAbbas"><img src="https://avatars.githubusercontent.com/u/11400357?v=4" />SyedAzeemAbbas</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <p>hi @dannye0231 I have resolved SVG issue </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dannye0231"><img src="https://avatars.githubusercontent.com/u/143747522?v=4" />dannye0231</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <p>Hi @SyedAzeemAbbas , are you able to check the other error that is now showing up?</p> <p>Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'textGradient' ID should be pi-jazzcash-textGradient (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "textGradient".</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/SyedAzeemAbbas"><img src="https://avatars.githubusercontent.com/u/11400357?v=4" />SyedAzeemAbbas</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <p>yes i have gone through it and resolved this issue</p> <p>On Mon, Sep 30, 2024 at 11:43 PM Danny Elisha <strong><em>@</em></strong>.***> wrote:</p> <blockquote> <p>Hi @SyedAzeemAbbas <a href="https://github.com/SyedAzeemAbbas">https://github.com/SyedAzeemAbbas</a> , are you able to check the other error that is now showing up?</p> <p>Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'textGradient' ID should be pi-jazzcash-textGradient (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "textGradient".</p> <p>— Reply to this email directly, view it on GitHub <a href="https://github.com/activemerchant/payment_icons/pull/1231#issuecomment-2383914674">https://github.com/activemerchant/payment_icons/pull/1231#issuecomment-2383914674</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/ACW7JJLSV5HPFBXESTLXS5TZZGLVFAVCNFSM6AAAAABPA4OSLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHEYTINRXGQ">https://github.com/notifications/unsubscribe-auth/ACW7JJLSV5HPFBXESTLXS5TZZGLVFAVCNFSM6AAAAABPA4OSLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHEYTINRXGQ</a> . You are receiving this because you were mentioned.Message ID: <strong><em>@</em></strong>.***></p> </blockquote> <p>-- <em>Syed Azeem Abbas</em> <em>+92 3453677361</em></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>