danielcivit
commented
3 weeks ago Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?
Open danielcivit opened 1 month ago
danielcivit
commented
3 weeks ago Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?
danielcivit
commented
2 weeks ago Hi @Lydia-shan-git.
Thanks for your review. We already passed the icon through SVGO following your guidelines: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md
svgo app/assets/images/payment_icons/multisafepay.svg --disable={removeUnknownsAndDefaults,removeTitle,cleanupIDs,removeViewBox}
multisafepay.svg:
Done in 10 ms!
2.555 KiB - 0% = 2.555 KiBAs you can see, with that ruleset, there is no change in the size of the file.
danielcivit
commented
1 week ago Hi @Lydia-shan-git
Thank you for checking and approving this pull request.
We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that due to this it may go unnoticed in the next release, thus delaying taking advantage of these changes.
Why are you adding this icons?
MultiSafepay payment icon is missing. MultiSafepay has pioneered Europe's most personalized payments ecosystem for small to medium-sized businesses and marketplaces. More than 18,000 businesses have simplified their market expansion and freed up time to focus on innovation with MultiSafepay's end-to-end payments toolkit.
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.ymlIf this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?