Add Pay After Delivery installments

danielcivit commented 1 month ago

Why are you adding this icons?

Pay After Delivery is MultiSafepay's BNPL method that allows customers to pay for orders in 3 equal installments within a period of time. This icon is missing and MultiSafepay is submitting a new payment app, to offer this payment method to our merchants.

Help us identify yourself

[X] I'm working/collaborating with the brand directly and they have provided the icons.
[ ] I'm associated with the brand and I've read all the brand icon’s guidelines.
[ ] I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

[X] All icons have a corresponding entry in db/payment_icons.yml
[X] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
[X] I have optimized the icon with SVGO
[X] I am confident that all icons are clear and easy to read/understand
[X] I have provided a link to the brand icon’s brand guidelines whenever possible.
[X] I have attached a screenshot comparison with the example icon provided in guidelines
[X] I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

comparison-bnpl

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" role="img" viewBox="0 0 38 24" width="38" height="24" aria-labelledby="pi-payafterdeliveryinstalments"><title id="pi-payafterdeliveryinstalments">Pay After Delivery Installments</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path fill="#b9b5b5" d="M20.97 6.813h-.538v10.754h.538V6.813z"/><path fill="#fabd00" d="M15.416 5.738l-.004.304h-.002V9.03a3.611 3.611 0 00-1.887-.502c-.49 0-.945.082-1.364.244a3.595 3.595 0 00-1.4.987.018.018 0 01.003.003c.595.674.888 1.491.888 2.433 0-.547.173-1 .51-1.357l.015-.017c.36-.362.806-.544 1.348-.544.54 0 .984.182 1.345.544.362.36.542.818.542 1.374 0 .557-.18 1.014-.542 1.376-.361.36-.806.542-1.345.542-.542 0-.988-.182-1.348-.542l-.016-.017c-.336-.359-.509-.81-.509-1.359 0 .943-.293 1.74-.888 2.415-.005.006-.01.013-.017.019a3.508 3.508 0 001.414.995c.419.16.875.238 1.364.238 1.025 0 1.902-.347 2.61-1.056.691-.69 1.051-1.54 1.069-2.537.002-.025.002-.049.002-.074V8.524c0-1.243-.732-2.279-1.788-2.786z"/><path fill="#00abee" d="M9.86 12.194c0 .556-.183 1.014-.53 1.373-.36.362-.805.544-1.347.544-.029 0-.057 0-.086-.002a1.81 1.81 0 01-1.26-.542c-.36-.36-.541-.819-.541-1.375s.18-1.014.542-1.375a1.814 1.814 0 011.345-.542c.542 0 .988.182 1.348.542.346.361.53.82.53 1.377 0-.942.288-1.742.883-2.416l.017-.02a3.034 3.034 0 00-.165-.177c-.709-.708-1.585-1.055-2.613-1.055l-.086.001c-.988.019-1.835.365-2.524 1.054-.691.691-1.052 1.54-1.069 2.538-.003.024-.003.049-.003.073v3.672c0 1.243.733 2.27 1.789 2.778l.004-.297h.002v-2.987a3.592 3.592 0 001.887.502c1.028 0 1.904-.361 2.613-1.07a2.51 2.51 0 00.15-.161l-.002-.003c-.595-.674-.884-1.49-.884-2.432z"/><path fill="#006693" d="M11.653 12.196c0 .942-.294 1.74-.889 2.414-.005.006-.01.013-.017.019l-.002-.003c-.595-.674-.884-1.49-.884-2.432s.289-1.742.884-2.416c.005-.006.01-.013.017-.019l.002.003c.595.674.889 1.492.889 2.434z"/><g fill="#00abee" transform="matrix(.53 0 0 .53 0 1.59)"><path d="M58.84 12.899h-1.014v-.254a.761.761 0 00-1.522 0v.254h-5.072v-.254a.761.761 0 00-1.522 0v.254h-1.014a3.047 3.047 0 00-3.044 3.043v9.13a3.047 3.047 0 003.044 3.044H58.84a3.047 3.047 0 003.043-3.044v-9.13a3.047 3.047 0 00-3.043-3.043zm1.522 12.173c0 .84-.682 1.522-1.521 1.522H48.696c-.84 0-1.522-.682-1.522-1.522v-6.594h13.188v6.594zm-13.188-8.115v-1.015c0-.84.683-1.522 1.522-1.522h1.014v.761a.761.761 0 001.522 0v-.76h5.072v.76a.761.761 0 001.522 0v-.76h1.015c.839 0 1.521.682 1.521 1.521v1.015H47.174z"/><circle cx="49.71" cy="22.536" r="1.522"/><circle cx="53.768" cy="22.536" r="1.522"/><circle cx="57.826" cy="22.536" r="1.522"/></g></svg>

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

danielcivit commented 3 weeks ago

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

danielcivit commented 2 weeks ago

Hi @Lydia-shan-git.

Thanks for your review. We already passed the icon through SVGO following your guidelines: https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md

svgo app/assets/images/payment_icons/payafterdeliveryinstalments.svg --disable={removeUnknownsAndDefaults,removeTitle,cleanupIDs,removeViewBox}

payafterdeliveryinstalments.svg:
Done in 11 ms!
2.671 KiB - 0% = 2.671 KiB

As you can see, with that ruleset, there is no change in the size of the file.

danielcivit commented 1 week ago

Hi @Lydia-shan-git

Thank you for checking and approving this pull request.

We are concerned that even after approval, this pull request is still tagged as " Changes Requested", and that due to this it may go unnoticed in the next release, thus delaying taking advantage of these changes.

Could you please let us know if this change will be included?
Could you please consider fixing the tagging to avoid confusion?
Could you please let us know when you plan to do the next release?

activemerchant / payment_icons