activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
149 stars 436 forks source link

Update "kbc_cbc" payment icon #1242

Open danielcivit opened 1 month ago

danielcivit commented 1 month ago

Why are you adding this icons?

I'm adding/updating this icon(s) because is outdated (wrong blue color, logo not centered and incorrectly scaled)

Help us identify yourself

Link to the brand guidelines: https://www.kbc.com/en/newsroom/media-gallery/logo-s-kbc-group.html

Checklist to add new icons

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

comparison-3

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" role="img" viewBox="0 0 38 24" fill="none" width="38" height="24" aria-labelledby="pi-kbc_cbc"><title id="pi-kbc_cbc">KBC</title><rect x="1" y="1" width="36" height="22" rx="2" fill="#fff"/><rect x=".5" y=".5" width="37" height="23" rx="2.5" stroke="#000" stroke-opacity=".07"/>&quot;/&gt;<path fill-rule="evenodd" clip-rule="evenodd" d="M19.047 5.019a3.091 3.091 0 11.114 6.18 3.091 3.091 0 01-.114-6.18z" fill="#009fe4"/><path fill-rule="evenodd" clip-rule="evenodd" d="M21.384 10.61a4.062 4.062 0 01-2.96 1.277 4.102 4.102 0 01-2.49-.849 71.189 71.189 0 00-5.883.856v1.367l17.9-.002v-2.817s-3.066-.02-6.567.168z" fill="#009fe4"/><path fill-rule="evenodd" clip-rule="evenodd" d="M12.176 17.256v1.664H10.05v-4.429h2.126v1.993h.012l1.252-1.993h2.55l-1.867 2.29 1.761 2.14h-2.433l-1.26-1.665h-.015zm15.774 1.481a6.386 6.386 0 01-1.751.244c-2.104 0-3.648-.598-3.648-2.337 0-1.572 1.497-2.255 3.543-2.255.569 0 1.291.063 1.856.244v1.522a2.586 2.586 0 00-1.438-.412c-.78 0-1.56.385-1.56.943 0 .559.776.942 1.56.942.59 0 1.019-.163 1.438-.405v1.514zm-11.612-4.246h4.298c1.117 0 1.483.435 1.483 1.11 0 .757-.676 1.086-1.37 1.123v.013c.712.056 1.407.136 1.407 1.03 0 .583-.366 1.153-1.594 1.153h-4.224v-4.429zm2.126 3.529h1.109c.416 0 .557-.172.557-.426 0-.255-.143-.437-.552-.437h-1.114v.863zm0-1.652h1.06c.409 0 .57-.166.57-.42 0-.291-.163-.437-.541-.437h-1.089v.857z" fill="#003664"/></svg>

<br>
<!-- TODO: insert your icon here -->
<YOUR SVG CODE>
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

danielcivit commented 3 weeks ago

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?