Update Breadpay icon - Githubissues

activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons

MIT License

150 stars 440 forks source link

Update Breadpay icon #1248

Open fkhan-bread opened 2 weeks ago

fkhan-bread commented 2 weeks ago

Why are you adding this icons?

Updating Bread Pay icon to the most recent branding

Help us identify yourself

[ ] I'm working/collaborating with the brand directly and they have provided the icons.
[x] I'm associated with the brand and I've read all the brand icon’s guidelines.
[ ] I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Attach a screenshot of the icon along side the example Visa icon

Screenshot 2024-11-08 at 9 45 43 AM

dannye0231 commented 2 days ago

Hi @fkhan-bread , can you check your tags? There is an issue with the SVG:

Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'g4' ID should be pi-breadpay-g4 (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "g4".

rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61

.....