Build a tool to define SVG

activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons

MIT License

144 stars 422 forks source link

Build a tool to define SVG #184

Open tauthomas01 opened 5 years ago

tauthomas01 commented 5 years ago

Issue

New icon requests require manual review and such process takes time. What if we could create a tool that could simplify the workflow and reduce manual work.

The following issues are some examples of what the tool can take care of: https://github.com/activemerchant/payment_icons/issues/183 https://github.com/activemerchant/payment_icons/issues/182 https://github.com/activemerchant/payment_icons/issues/179

Proposed solution

There could be a tool that reads the generated SVG, reviews the structure and modifies the file according to some requirements we establish so the contributors won't have to manually modify inside the file.

tauthomas01 commented 5 years ago

cc. @NathanPJF

NathanPJF commented 5 years ago

Thanks for making a note of this. It would be cool if

Contributions are only for the icon in a new directory like app/assets/svg/payment_icons
We put the border path and background-color ourselves in a build tool, and generate a new icon for app/assets/images/payment_icons
Contributors could specify the background (if they don't want white) in a separate place like payment_icons.yml

So American express entry becomes

  name: american_express
  label: American Express
  color: #032761
  group: credit_cards