activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons
MIT License
141 stars 407 forks source link

Hong Kong - New Payment Icons: AlipayHK and Octopus #422

Open frankietyng opened 3 years ago

frankietyng commented 3 years ago

One of our partners is now adding two additional local wallets: AlipayHK and Octopus. It should be noted that the AlipayHK icon is different from the Alipay (China) icon. Image files for logos attached

For context, this is a QR-code based payment method that will sit within their HPSDK integration alongside other digital wallets like WeChat Pay and FPS.

Help Needed

  1. Add to the admin as a selectable payment method through the QFPay integration
  2. Make the 'AlipayHK' and 'Octopus' icon (attached) visible at checkout when customer is selecting Payment method (=QFPay)

AlipayHK - Logo Octopus - Logo

larouxn commented 3 years ago

Hey @frankietyng, will the partner be able to open a pull request against this repository to add those two new icons?

👋 @shopiwags, are we okay with this new AliPay icon? Considering we just consolidated the other two into one.

rymwoo commented 3 years ago

@frankietyng I'm curious to know who is the partner you've been working with? is it alipay?

frankietyng commented 3 years ago

@rymwoo Hey - they're called QFPay, aggregating a lot of very local wallets (https://www.qfpay.global/shopify-checkout) @larouxn asking - thanks :)

larouxn commented 3 years ago

@frankietyng, okay, please let me know if the partner will be opening a pull request by Monday. If they cannot, we can probably spin something up. Need to find SVGs of the icons and such though. (open to help finding them)

@zbriscoe, will keep you in the know re: AlipayHK.

larouxn commented 3 years ago

AliPay HK icon was merged and made live a week or two ago.

Leaving this open as we've yet to add Octopus.