change payment method name "Yahoo mobile" to "Y!mobile)

activemerchant / payment_icons

An easy to use library that allows you to manage and access payment icons

MIT License

144 stars 423 forks source link

change payment method name "Yahoo mobile" to "Y!mobile) #459

Closed iwasakis closed 3 years ago

iwasakis commented 3 years ago

Hi @larouxn

Would you correct the string of telco name "Yahoo mobile (in Japanese ヤフーモバイル)" to "Y!mobile (same in Japanese Y!mobile)"

--"Yahoo mobile" is a mobile web portal provided by "Yahoo Japan Corporation" --"Y!mobile" is a brand of the mobile network provided by "Softbank Cooperation"

https://github.com/activemerchant/payment_icons/pull/277

Thanks, Satoshi

larouxn commented 3 years ago

Hello @iwasakis, I'm seeing some issues with renaming to a name including !. If you can publish a PR that renames the yahoo_mobile.svg icon and manifest entry and achieves green CI, I'd be willing to review and potentially merge it. https://github.com/activemerchant/payment_icons/blob/45da15340037403d0061cf1712125fa22d3713ef/db/payment_icons.yml#L733-L736

Additionally, for what it's worth, if I Google "yahoo mobile" it actually returns many "Y!mobile" resources. 🤔

iwasakis commented 3 years ago

HI @larouxn, I could not publish PR from some internal restriction, I would like to have your support. In case when we cannot use exclamation marks, Ymobile also works.

Regarding your question, the second and third results are actually a page of "Ymobile" over "yahoo mobile" portal.

Please refer wikipedia JP for those two difference; Yahoo mobile Y!mobile

larouxn commented 3 years ago

👋 @iwasakis, how does this look? https://github.com/activemerchant/payment_icons/pull/462

iwasakis commented 3 years ago

@larouxn Thank you so much for your all deployment effort, looks perfect!

larouxn commented 3 years ago

Released as part of v1.7.0 by the way.