Remove age_in_days and is_expired - Githubissues

activeprospect / leadconduit-types

This Node.JS module parses lead data and provides specialized functionality by lead data category.

1 stars 0 forks source link

Remove age_in_days and is_expired #145

Closed alexkwolfe closed 2 years ago

alexkwolfe commented 2 years ago

Description of the change

Removed these properties in response to feedback from product and sales. I'm labeling this a bug fix since it's not in production yet.

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Configuration change
[ ] Technical Debt
[ ] Documentation

Related tickets

Shortcut #37783

Checklists

Development and Testing

[X] Lint rules pass locally.
[X] The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
[X] All tests related to the changed code pass in development, or tests are not applicable.

Code Review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
[ ] At least two engineers have been added as "Reviewers" on the pull request.
[ ] Changes have been reviewed by at least two other engineers who did not write the code.
[ ] This branch has been rebased off master to be current.

Tracking

[ ] Issue from Shortcut has a link to this pull request.
[ ] This PR has a link to the issue in Shortcut.

QA

[ ] This branch has been deployed to staging and tested.

shortcut-integration[bot] commented 2 years ago

This pull request has been linked to Shortcut Story #37783: TrustedForm Cert URL Type.