activeprospect / leadconduit-types

This Node.JS module parses lead data and provides specialized functionality by lead data category.
1 stars 0 forks source link

mask dob fields #151

Closed jgrayson676 closed 2 years ago

jgrayson676 commented 2 years ago

Description of the change

this updates the mask function to support dob type fields and enables masking for dob fields

Type of change

Related tickets

https://app.shortcut.com/active-prospect/story/36550/user-views-obscured-dob-in-lead-details-view

Checklists

Development and Testing

Code Review

Tracking

QA

shortcut-integration[bot] commented 2 years ago

This pull request has been linked to Shortcut Story #36550: User Views Obscured DoB in Lead Details View.

asedarski commented 2 years ago

I think these changes might need to take place in https://github.com/activeprospect/leadconduit-mask instead of (or maybe in addition to) leadconduit-types since that is what we're using to mask the types now in send.js https://github.com/activeprospect/leadconduit-api/blob/master/lib/handler/util/send.js#L505

richardfordjunior commented 2 years ago

Good catch @Alicia Sedarski @.***> I totally forgot about this library.🙁

On Thu, Sep 1, 2022 at 4:10 PM Alicia Sedarski @.***> wrote:

I think these changes might need to take place in https://github.com/activeprospect/leadconduit-mask instead of leadconduit-types since that is what we're using to mask the types now in send.js

https://github.com/activeprospect/leadconduit-api/blob/master/lib/handler/util/send.js#L505

— Reply to this email directly, view it on GitHub https://github.com/activeprospect/leadconduit-types/pull/151#issuecomment-1234730050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE36H5QI45B55RNAFA7ZHTV4EERRANCNFSM6AAAAAAQCT7DZY . You are receiving this because your review was requested.Message ID: @.***>