activeprospect / leadconduit-types

This Node.JS module parses lead data and provides specialized functionality by lead data category.
1 stars 0 forks source link

sc-57182/fix-date-masking #159

Closed johnrb2 closed 1 year ago

johnrb2 commented 1 year ago

Description of the change

fix logic for masking dates

Type of change

Related tickets

https://app.shortcut.com/active-prospect/story/57182/fix-date-masking

Checklists

Development and Testing

Code Review

Tracking

QA

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #57182: fix date masking.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c9f5e29) 97.43% compared to head (f526291) 97.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #159 +/- ## ======================================= Coverage 97.43% 97.43% ======================================= Files 37 37 Lines 701 702 +1 ======================================= + Hits 683 684 +1 Misses 18 18 ``` | [Impacted Files](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect) | Coverage Δ | | |---|---|---| | [lib/aggregations/date.js](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect#diff-bGliL2FnZ3JlZ2F0aW9ucy9kYXRlLmpz) | `100.00% <100.00%> (ø)` | | | [lib/index.js](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect#diff-bGliL2luZGV4Lmpz) | `87.23% <100.00%> (ø)` | | | [lib/types/date.js](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect#diff-bGliL3R5cGVzL2RhdGUuanM=) | `96.15% <100.00%> (+0.32%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.