activeprospect / leadconduit-types

This Node.JS module parses lead data and provides specialized functionality by lead data category.
1 stars 0 forks source link

sc-64578/fix-invalid-url-bug #169

Closed johnrb2 closed 1 year ago

johnrb2 commented 1 year ago

Description of the change

add try/catch for invalid domain; run lint:fix

Type of change

Related tickets

https://app.shortcut.com/active-prospect/story/64578/fix-invalid-url-bug

Checklists

Development and Testing

Code Review

Tracking

QA

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #64578: fix invalid url bug.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8cd6a91) 97.56% compared to head (d436eaf) 97.54%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #169 +/- ## ========================================== - Coverage 97.56% 97.54% -0.03% ========================================== Files 38 38 Lines 739 732 -7 ========================================== - Hits 721 714 -7 Misses 18 18 ``` | [Files](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect) | Coverage Δ | | |---|---|---| | [lib/types/email.js](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect#diff-bGliL3R5cGVzL2VtYWlsLmpz) | `100.00% <100.00%> (ø)` | | | [lib/types/trustedform\_url.js](https://app.codecov.io/gh/activeprospect/leadconduit-types/pull/169?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=activeprospect#diff-bGliL3R5cGVzL3RydXN0ZWRmb3JtX3VybC5qcw==) | `96.92% <100.00%> (-0.42%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johnrb2 commented 1 year ago

v16 test will go away once this branch is merged to master