This PR is addressing an error we are experiencing on edge rails. This error is caused because the API for creating an ActiveRecord::Associations::AliasTrackerhas changed in edge rails. It now wants to eat a connection pool rather than a connection. Knowing nothing about ransack's internals, from what I can tell it shouldn't need to use this API directly, and should just ask it's ActiveRecord::Relation to create a fresh AliasTracker instead. This patch includes my naive way of doing so. It fixes the breakages in our own test suite. Please let me know if there are other additions I should include.
tagliala
commented
2 weeks ago
Closes #1491.
This PR is addressing an error we are experiencing on edge rails. This error is caused because the API for creating an
ActiveRecord::Associations::AliasTrackerhas changed in edge rails. It now wants to eat a connection pool rather than a connection. Knowing nothing about ransack's internals, from what I can tell it shouldn't need to use this API directly, and should just ask it'sActiveRecord::Relationto create a freshAliasTrackerinstead. This patch includes my naive way of doing so. It fixes the breakages in our own test suite. Please let me know if there are other additions I should include.