search

activescaffold / active_scaffold

Save time and headaches, and create a more easily maintainable set of pages, with ActiveScaffold. ActiveScaffold handles all your CRUD (create, read, update, delete) user interface needs, leaving you more time to focus on more challenging (and interesting!) problems.
MIT License
1.09k stars 327 forks source link

What about twitter bootstrap? #468

Open bmalets opened 8 years ago

bmalets commented 8 years ago

Hi guys!

Thank you for such a cool gem, it really facilitates and speeds up development. But do you have in plans to replace a default theme with twitter-bootstrap? :innocent:

І have looked for bootstrap in active_scaffold's analogs, forks, issues and pull requests but did not found any results.

As I see in source code, it will be not easy....

Thanks, @bmalets

scambra commented 8 years ago

no plan in changing theme, it may be a big work

bmalets commented 8 years ago

Thanks for a quick answer.

scambra commented 8 years ago

I don't know much about twitter-bootstrap, but I guess html structure and classes needs to be changed, or maybe not changing classes, only adding them.

Also, I would rather to add twitter bootstrap as a theme, so people can choose current or twitter bootstrap. Probably views would be same, but included css would be current one or twitter-bootstrap ones.

What do you think? Were you thinking only on CSS or JS too?

naaano commented 8 years ago

it gets weird when you mix bootstrap styles with base bootstrap. It would be great if the theme would work back again. I would help to migrate. JS shouldn't be much conflict, since AS is focused on functionality(remote calls, mostly) and bootstrap js is more about appearance effects. The bigger deal i think it would be to adapt helpers, which need to include some classes and different markup in some cases.

CCH4GITHUB commented 7 years ago

Hi Sergio

Yes, I agree that I would also rather to add twitter bootstrap as a theme, so people can choose current or twitter bootstrap :-)