search

activescott / lessmsi

A tool to view and extract the contents of an Windows Installer (.msi) file.
https://lessmsi.activescott.com
MIT License
1.29k stars 150 forks source link

Error closing lessmsi-gui - permission issue #190

Closed Nurple closed 4 months ago

Nurple commented 4 months ago

Describe the bug: Heya, since updating to v1.11.0, closing lessmsi is causing an error as it tries to write to lessmsi-gui.exe.config in the "install" directory, which fails as it's write protected.

To Reproduce: Steps to reproduce the behavior:

  1. Open lessmsi-gui
  2. Move / Resize window
  3. Close lessmsi-gui

Expected behavior: Save the window size / position settings under C:\Users\~\AppData\Local\LessMsi like other settings.

Screenshot:

Error

Desktop:

activescott commented 4 months ago

@Nurple Thank you for reporting and sorry about the trouble. We'll get it fixed up!

@mega5800 Can you please investigate. I should have thought more about the location of saving. You can see how other settings are saved in the LoadPreferences and SavePreferences method at https://github.com/activescott/lessmsi/blob/83e57cf400bc2b6fe2727907304e3641e01293a4/src/LessMsi.Gui/MruMenuStripManager.cs#L67 Can you please change to using that general technique for persisting settings?

mega5800 commented 4 months ago

@activescott @Nurple Thank you for bringing this matter to my attention, and sorry for any inconvenience caused. I will investigate this issue during the weekend, and hopefully will have a fix by Monday.

activescott commented 4 months ago

Thanks @mega5800 - Not super urgent from my side. If you feel like it's taking you too long or you want a hand let me know! Thanks again!!

activescott commented 4 months ago

:tada: This issue has been resolved in version 1.11.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Nurple commented 4 months ago

Thanks for the fix.