search

activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
225 stars 185 forks source link

Discussion of converting transitions to Headless UI transition #500

Open andrewtavis opened 11 months ago

andrewtavis commented 11 months ago

Terms

Description

activist is trying to extensively use Headless UI for accessible components. One thing that we've year to use is the transition component of theirs. Specifically this would bring our transitions more in line with a baseline software we're using for more complex aspects of the frontend, and would also help us transition to fully having all the styling within the <template> blocks as as of now we're still using <style> blocks for transitions.

Would be great to discuss this and then if we decide to make the conversion we can map out what components need to change and keep track of the progress here 😊

Contribution

Would be happy to work on this with people! New contributors are also welcome to join in and share their opinions :)

andrewtavis commented 11 months ago

@ahmedy00, can I get your opinion on this? :)

ahmedy00 commented 11 months ago

Hey @andrewtavis, it seems to make sense, if you would like to assign it to me, please feel free

andrewtavis commented 11 months ago

Sure, thank you @ahmedy00! Let me know if you want some help documenting where the changes need to happen :) :)

andrewtavis commented 10 months ago

Hey @ahmedy00 👋 Let me know what you're thinking on this one :) Would also be happy to do a call to discuss if you'd be interested!

ahmedy00 commented 10 months ago

Hey @andrewtavis, I've been a bit sick for a few days. I will start this task asap

andrewtavis commented 10 months ago

Thanks @ahmedy00! Sorry that you haven't been feeling well :( Let me know if there's anything I can do to help! We'll be making backend issues soon, btw, so there should be a new one for you 😊

andrewtavis commented 4 months ago

Unassigning so that we can open this one up for someone else, @ahmedy00 :) We just talked about it, and implementing the transitions in this way would also help us document where they're present via the component.

Hope you're doing well! Let me know if you'd like to do a call at some point to check in. Would be great to work with you again 😊

ahmedy00 commented 4 months ago

Hey @andrewtavis , I'm doing well, thank you, hope you are too.It was great work with you as well. Unfortunately I'm not able to rejoin at the moment, but I'll definitely keep it in mind.

andrewtavis commented 4 months ago

Looking forward to it if and when it works out, @ahmedy00!