Expand ESLint with further rules

activist-org / activist

An open-source activism platform

https://activist.org

GNU Affero General Public License v3.0

225 stars 185 forks source link

Expand ESLint with further rules #544

Open andrewtavis opened 10 months ago

andrewtavis commented 10 months ago

Terms

[X] I have searched open and closed feature requests
[X] I agree to follow activist's Code of Conduct

Description

This issue is to discuss and add new ESLint rules and also to refactor the codebase as needed to make it compliant after the changes :)

Contribution

@Robert-Kovalcuk had some ideas of some rules that we should add. Let's discuss and we can check in with some others and go from there!

andrewtavis commented 10 months ago

CC @to-sta :)

Robert-Kovalcuk commented 10 months ago

Yes, I'll definitely have a look at that, out of the top of my mind I think, we should enforce multi-word components

andrewtavis commented 10 months ago

Thanks @Robert-Kovalcuk!

to-sta commented 10 months ago

@Robert-Kovalcuk good idea 💯.

to-sta commented 10 months ago

Checking for type any would be interesting. Maybe there is a rule for disallowing type any.

andrewtavis commented 6 months ago

CC @lucianmurmurache: this is the ESLint issue I was talking with you about. @Robert-Kovalcuk, @lucianmurmurache is adding things into the ESLint setup to expand a11y linting. Figured adding him into the discussion makes sense 😊

andrewtavis commented 5 months ago

Hey @Robert-Kovalcuk 👋 Checking in on this one as it definitely would be good to expand the rules again soon :) Let me know if you have time for a call soon!