Closed aasimsyed closed 5 months ago
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local activist repo[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Name | Link |
---|---|
Latest commit | d86178c0207e890bff0c46dfd81255c653364be4 |
Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/6635528a55f44f0008474c66 |
Deploy Preview | https://deploy-preview-838--activist-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
for this PR to pass, the pr_ci_frontend.yaml
and the project's GitHub secrets/environment will need to match.
Hey @aasimsyed 👋 Discussing all of this now with @to-sta and @wkyoshida :)
e2e.yaml
would likely be better (I had said we should include it in the frontend PR workflow, but given the timing it's taking we should make a single one)Let me know if you'd like to connect on all of this in the future. After Wednesday would be ideal, and I'm off Thursday and Friday 😊
@andrewtavis please take a new look at this. I have addressed your comments and restored the pr_ci_frontend.yaml
from upstream/main
, creating a separate pr_ci_playwright_e2e.yaml
for Playwright E2E that is not automatically triggered (while it's a WIP). I made the Playwright one with the below trigger, which I think adds a button to manually run on GitHub if it's on the default branch:
workflow_dispatch:
I also added a couple of ids on LandingSplash.vue
for easier locators, if that is OK.
Thanks, @aasimsyed!
Contributor checklist
Description
This PR removes Cypress and adds Playwright in its place as well as updates the GitHub Actions workfile
pr_ci_frontend.yaml
for CI testing.dev
environment for it to work.Changes in this PR:
frontend/package.json
-- to run against local (assuming server is running):yarn test:local
-- to run against prod:yarn test:prod
-- to run either using Playwright UI, append--ui
on either commandpr_ci_frontend.yaml
to include server start/stop and run playwright testsdocker-compose.yml
to include health checkyarn test:local
,yarn test:prod
, andyarn playwright test
andRelated issue
829