activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
225 stars 185 forks source link

Chore/implement playwright axe and axe core #838

Closed aasimsyed closed 5 months ago

aasimsyed commented 5 months ago

Contributor checklist


Description

This PR removes Cypress and adds Playwright in its place as well as updates the GitHub Actions workfile pr_ci_frontend.yaml for CI testing.

Changes in this PR:

Related issue

github-actions[bot] commented 5 months ago

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

netlify[bot] commented 5 months ago

Deploy Preview for activist-org ready!

Name Link
Latest commit d86178c0207e890bff0c46dfd81255c653364be4
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6635528a55f44f0008474c66
Deploy Preview https://deploy-preview-838--activist-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aasimsyed commented 5 months ago

for this PR to pass, the pr_ci_frontend.yaml and the project's GitHub secrets/environment will need to match.

andrewtavis commented 5 months ago

Hey @aasimsyed 👋 Discussing all of this now with @to-sta and @wkyoshida :)

Let me know if you'd like to connect on all of this in the future. After Wednesday would be ideal, and I'm off Thursday and Friday 😊

aasimsyed commented 5 months ago

@andrewtavis please take a new look at this. I have addressed your comments and restored the pr_ci_frontend.yaml from upstream/main, creating a separate pr_ci_playwright_e2e.yaml for Playwright E2E that is not automatically triggered (while it's a WIP). I made the Playwright one with the below trigger, which I think adds a button to manually run on GitHub if it's on the default branch:

  workflow_dispatch:

I also added a couple of ids on LandingSplash.vue for easier locators, if that is OK.

andrewtavis commented 5 months ago

Thanks, @aasimsyed!