activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
225 stars 185 forks source link

Refactor search result components to propogate to CardSearchResult #851

Closed andrewtavis closed 5 months ago

andrewtavis commented 5 months ago

Terms

Issue

Something that would be helpful to do at some point would be to refactor all of the search result components such that CardSearchResult contains all of the styling for the components and is loaded into the other ones. We'd then apply <CardSearchResultTYPE /> in the UI rather than <CardSearchResult /> with an entity passed to it. In this way we'd be able to not have so much code repetition within each of the individual search result components. CardSearchResult would need props for each of the given parts, with these then being styled based on which type of entity is passed (organization, group, etc).

This would be a great good first issue for someone wanting to get into activist coding! Happy to support or work on it myself eventually 😊

andrewtavis commented 5 months ago

I'm realizing I should do this such that it's easier to do the links that are needed now in a maintainable way :)

andrewtavis commented 5 months ago

Closed via d8bd2b0 🥳