search

activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
225 stars 185 forks source link

Org and event index pages don't route to about on resize to the page being larger #858

Closed andrewtavis closed 5 months ago

andrewtavis commented 5 months ago

Terms

Behavior

In #856 a bug was fixed that would route to a double id on an about change on resize the page to being smaller. The tradeoff though was that now the route doesn't change to about if we start on the small breakpoint and move to the larger ones. Changes for this would specifically need to happen within pages/organizations/[id]/about and pages/events/[id]/about, with the commit that fixed the bug being a good place to check on all of this (resizing from small to large used to work).

This is a great good first issue for someone wanting to try working on activist! Happy to discuss and support as needed 😊

nicomaz commented 5 months ago

Hi, I've been having a look at this and if it's still up for grabs, I'd love to work on it.

andrewtavis commented 5 months ago

Hey @nicomaz 👋 We'd be grateful for the support here! Will assign you now, and let us know if there's anything we can do to help :)

andrewtavis commented 5 months ago

Closed by #860 🚀 Appreciate the contribution, @nicomaz! Would be happy to work with you again :) #857 is likely the same? Do you want to pick that up as well?

nicomaz commented 5 months ago

Appreciate the opportunity and glad to help! Sounds good, I'll have a look now. :-)

andrewtavis commented 5 months ago

Feel free to write in there if you're interested and I'd be happy to assign :)