github-actions[bot]
commented
5 months ago Thank you for the pull request!
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!
Maintainer checklist
-
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local activist repo
-
[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
-
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
netlify[bot]
…f email
Contributor checklist
Description
In this PR, I have started working on the login. I have changed the serializer to use the
usernameinstead of theemail. There are still some missing pieces:Notes:
I was thinking about the password indicator on login. Since the user already has an account and a password, it seems unnecessary to me.
How are we showing login errors to the user?
I used the
$fetchinstead ofuseFetchbecause nuxt, displayed a suggestion in the console:I have tested a successful login and a bad request.
Related issue