activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
225 stars 185 forks source link

Components are being hidden within their templates rather than in their instances #862

Closed andrewtavis closed 5 months ago

andrewtavis commented 5 months ago

Terms

Behavior

This is doubtless causing some massive slowdown in how the application is performing... We're applying class="hidden md:block" and the like within the components themselves rather than at the level of their instances, with this meaning that the TypeScript in the script blocks is still running even when the component itself is hidden.

I'll work on this!

andrewtavis commented 5 months ago

Basically the goal here is, if a component has hidden in the highest level of its template, then this and the corresponding block/flex should be put on the instances of the component :)

andrewtavis commented 5 months ago

Closed by d25c07d 😊