activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
225 stars 185 forks source link

Apply layouts across directories and clean up sidebar assignment #869

Closed andrewtavis closed 5 months ago

andrewtavis commented 5 months ago

Terms

Description

Based on a conversation with @Robert-Kovalcuk, we need to separate the sidebar layout into different layouts and use them in a way that the pages take the given layout for the org page, event page, etc :) This will allow us to avoid prop drilling throughout the frontend to set the state of the sidebar index and filters.

Contribution

I'll work on this today/tomorrow 😊

andrewtavis commented 5 months ago

ad48d08 Closes this :) I actually didn't split it up into different layouts, as I think the combination of an update of the layouts such that they have <NuxtPage /> instead of <slot /> as well as cleaning up the ill-advised implementation was enough. The big problem with #532 was that the sidebar type itself was not reactive within the original sidebar, which is something I figured out as I was working on the new version. I'm assuming that that + the <NuxtPage /> is enough to make this cleaner approach possible 😊

Thanks for the discussion and the help, @Robert-Kovalcuk!