github-actions[bot]
commented
2 months ago Thank you for the pull request!
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
Maintainer checklist
-
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local activist repo
-
[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
-
[x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
-
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
netlify[bot]
Contributor checklist
Description
simplified this workflow file to just run the same docker command as used in the local env (but as daemon):
replaced curl in the web server wait to instead use the
wait-onutilityname: Wait for web server to be ready working-directory: ./frontend run: | yarn wait-on http://localhost:3000
added yarn cache clean
added the unmet peer dependency
'@opentelemetry/api@>=1.0.0 <1.9.0'Tested this on my fork: https://github.com/aasimsyed/activist/actions/runs/8952331263