activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
209 stars 173 forks source link

Only one modal open #881

Closed nicomaz closed 5 days ago

nicomaz commented 1 month ago

Contributor checklist


Description

When opening a modal inside another modal, make the previous modal close so that only one modal is open at a time. When opening a modal for the first time, it creates an instance of that modal on the pinia store. Prior to this, it closes all modals already in the store, ensuring that only one modal is open at a time.

Related issue

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

netlify[bot] commented 1 month ago

Deploy Preview for activist-org ready!

Name Link
Latest commit 33a3fa9fca00a6c82685fa506cce8107390c7642
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6681e41b2960c400081d9664
Deploy Preview https://deploy-preview-881--activist-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrewtavis commented 1 month ago

Looks like the frontend error might be for Prettier, @nicomaz? :) Do you want to try to fix this? Let me know if you need some support!

andrewtavis commented 1 month ago

Nice @nicomaz! Thank you 😊 Will get to the review here in the coming days :)

nicomaz commented 1 month ago

Thank you @andrewtavis. :-) If there's any other issue that you'd like for me to look at, feel free to tag me!

andrewtavis commented 1 month ago

Thanks for checking in to pick up something else, @nicomaz! one of the following would be great to get some support on:

Feel free to write into them if you're interested!

andrewtavis commented 6 days ago

Lots of merge conflicts from the recent changes, @nicomaz, and there might be a few issues with how I got rid of them all. I'll do another scan of it all tomorrow and we'll figure this out/get it in 😊

andrewtavis commented 6 days ago

Nice ok, at least tests are passing :) I'll check that all's working tomorrow!