Closed aasimsyed closed 4 days ago
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local activist repo[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Name | Link |
---|---|
Latest commit | 2fe7e6911f92947d947ac518f0a0e61b4cfd13c7 |
Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/6684425bc43bd30008cc9451 |
Deploy Preview | https://deploy-preview-886--activist-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@andrewtavis retested locally and good to merge now
GitHub Actions Workflow
Configuration and Dependencies
.yarnrc
file to ignore engines check.playwright
to1.44.0
.@playwright/test
to1.44.0
.playwright-core
dependency.playwright-core
to1.44.0
.Components
BtnRoadMap.vue:
id="btn-roadmap"
to the NuxtLink.BtnRouteExternal.vue and BtnRouteInternal.vue:
:id="id"
.DropdownLanguage.vue and DropdownTheme.vue:
"dropdown-language"
and"dropdown-theme"
.HeaderWebsite.vue:
id="header"
to the header."btn-get-in-touch-medium"
,"btn-get-in-touch-medium"
components.LandingContent.vue:
LogoActivist.vue:
logo-activist
class.SidebarRightHamburger.vue:
id="sidebar-right-hamburger"
to the button.Playwright Configuration
Component Objects
BaseComponent.ts:
HeaderWebsite.ts:
BasePage.ts:
LandingPage.ts:
Tests
Type Definitions
id
property to BtnRouteYarn Lock
Contributor checklist
Description
This PR implements the tests and associated page/component objects in Playwright for the Header on the Landing Page. It also adds a few configuration and workflow tweaks.
Related issue
ISSUE_NUMBER