Closed Robot8lover closed 5 days ago
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local activist repo[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Name | Link |
---|---|
Latest commit | 94a6dedf87bc57972abaa35c1b29f48bbf425ffa |
Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/668346047701f700084efa3c |
Deploy Preview | https://deploy-preview-889--activist-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Quick note on this for myself, I need to add in the following for the middleware after #818 is merged :)
definePageMeta({
middleware: ["user-only"],
});
Contributor checklist
Description
The event create flow is currently incomplete, with the other create flows being further along. This aims to introduce an event create flow design based on the Figma prototype and existing create flows (e.g. for organizations). The basic features including the paged single form design using
v-if
seem to work. Using aref
with vue models (taken from organizations create flow) enables saving of form data "across" pages, so entries will be populated after moving forwards or backwards. This also makes it easier to send the request data at the end. There are still features and components that will need to be implemented like validation, tooltips, organizer selection, roles, public/private publishing, and invitations.Also, I think I included the QR code changes in this branch. Sorry about that.
Related issue
560