activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
209 stars 173 forks source link

Fix component hiding #890

Closed Robot8lover closed 2 days ago

Robot8lover commented 1 month ago

Contributor checklist


Description

Exchange instances of hidden md:block or md:hidden and similar CSS based hiding techniques for v-if statements using breakpoints. As mentioned in #864, this has the advantage of not rendering these components, which is better for performance and usually desirable unless the window is being resized. If accounting for resizing windows is preferred, though it is usually not the case, then v-show could be used instead. I tried to keep any display property classes unless it was obvious they could be removed (e.g. block on a div). It is possible I reversed some of the logic due to a forgotten exclamation mark, which is one of the downsides of what I did. It may be better to explicitly write greaterOrEqual or lesser to avoid such errors. There were also some conditionally assigned hiding classes, which involve two boolean checks.

Related issue

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

netlify[bot] commented 1 month ago

Deploy Preview for activist-org ready!

Name Link
Latest commit 1fee2a49127f82c3a9e95ea0429b88e5928672b6
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66873a1f231168000831320d
Deploy Preview https://deploy-preview-890--activist-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrewtavis commented 1 month ago

Really appreciate all the work here, @Robot8lover! We have the dev sync on Saturday that you'd be more then welcome to :) If you can't make the sync, also let me know and I'd be happy to set up a call and answer any questions you might have!

I'll try to bring all the PRs in over the coming days 😊