Closed UnknownSean8 closed 3 weeks ago
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local activist repo[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
[ ] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
[ ] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Name | Link |
---|---|
Latest commit | b28c9c02d20e124f59399adc4df43f6f51d9e48d |
Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/6665e7d32fa30e000885d41b |
Deploy Preview | https://deploy-preview-896--activist-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Contributor checklist
Description
I just implemented the middleware in the events create route as I think most of the others are done. I also added a check in the admin guard as there's already a userIsAdmin variable in the store.
A few questions,
I might have missed it if it was discussed in the dev sync, sorry in advance and thanks!
Related issue
876