Closed thesarfo closed 1 week ago
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local activist repo[x] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Name | Link |
---|---|
Latest commit | e353594b77e389657071aea7ede70e2a6222654c |
Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/6680590dc2f9740008b01612 |
Thanks for sending this along, @thesarfo! We'll check it and get back with feedback as soon as we can :)
@thesarfo thanks for your PR ๐ . I fixed a few minor details and ran the tests successfully.
Thanks for the work here, @thesarfo! Give me just a moment to send along some changes, and then I'll take care of any merge conflicts in here. Should be in by the start of the weekend ๐
@andrewtavis anytime! And thanks for the opportunity๐
Contributor checklist
Description
This pull request proposes to add comprehensive tests for the password reset functionality in the authentication app. It aims to ensure that the password reset process works correctly and handles various scenarios properly.
Changes:
ISSUE_NUMBER
https://github.com/activist-org/activist/issues/898