activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
209 stars 173 forks source link

Fix #579: Add shadow to sidebar footer when content is scrollable #910

Open PustakP opened 1 week ago

PustakP commented 1 week ago

Contributor checklist


Description

This pull request addresses issue #579 by implementing a shadow effect on the sidebar footer when the content of the sidebar (either index or filters) is scrollable.

Changes made:

  1. Updated SidebarLeftFooter.vue to accept a new prop contentIsScrollable and apply a shadow when it's true.
  2. Modified SidebarLeftIndex.vue and SidebarLeftFilters.vue to detect when their content is scrollable and emit this information.
  3. Updated the parent component SidebarLeft.vue to pass the scrollable state from the index and filters components to the footer component.

Additional notes:

The changes primarily affect the following components:

Related issue

github-actions[bot] commented 1 week ago

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

netlify[bot] commented 1 week ago

Deploy Preview for activist-org ready!

Name Link
Latest commit 41e69aa47f0215e8b5e2526fd5a6c42fdf1584c4
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/667e930184ea9b00089b8c7b
Deploy Preview https://deploy-preview-910--activist-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrewtavis commented 1 week ago

Hey @PustakP 👋 Could you take a screenshot of the change you made and send it along? Also, if you'd like to work on the linting errors, let me know! Can also handle them for you if you'd prefer 😊

andrewtavis commented 1 week ago

I can also take care of the merge conflict as well. No stress 😎

PustakP commented 1 week ago

@andrewtavis Hi! Thank you for your response, super excited for this. I'll be out of town for a few days so I can't send through a screenshot right now, but I can start on the merge conflicts as soon as Tuesday. Thanks!

andrewtavis commented 1 week ago

Thank you, @PustakP! Looking forward to working on this with you further :)