Closed andrewtavis closed 1 week ago
The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local activist repo[ ] The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Name | Link |
---|---|
Latest commit | d8a1bb09463b18809f89cb68e9e2a7dbf4ffb1bd |
Latest deploy log | https://app.netlify.com/sites/activist-org/deploys/6680305b37b4310009e20030 |
Deploy Preview | https://deploy-preview-911--activist-org.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Contributor checklist
Description
LOTS of changes to hydrate organization about pages and the index.
Please note that due to #872 I wasn't able to effectively run the frontend type check as I don't want to have to redo
yarn.lock
because of the upstream bug where we'd need to rebuild the node modules, but then that would reset the lock file and cause even more merge conflicts than this is already going to.Will test in here and then merge in!
Related issue
812