activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
209 stars 173 forks source link

org_text adjustments #921

Open to-sta opened 5 days ago

to-sta commented 5 days ago

Contributor checklist


Description

I adjusted the org API to create the OrganizationText for POST requests.

ToDo:

Related issue

github-actions[bot] commented 5 days ago

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

netlify[bot] commented 5 days ago

Deploy Preview for activist-org ready!

Name Link
Latest commit 9adb6448eed5ae089874b9ebcbeb13e9bab6c4f7
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6688668afe2aa60008df5480
Deploy Preview https://deploy-preview-921--activist-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrewtavis commented 5 days ago

Thanks for this, @to-sta!

Are you planning on adding Toast yourself, or should I check this? And let me know what changes should generally happen in the organization store :)

to-sta commented 5 days ago

@andrewtavis I will give it a try, with vue-sonner.

We don't need the OrganizationText POST request anymore in the store. I can remove it myself while working on the toast 🤗

andrewtavis commented 5 days ago

Sounds good! Thanks, @to-sta!

to-sta commented 1 day ago

Removed OrganizationText request and added in the vue sonner toast in the bottom left.

andrewtavis commented 1 day ago

Nice, @to-sta! Should I look into the conflicts from here? Let me know :)

to-sta commented 1 day ago

Nice, @to-sta! Should I look into the conflicts from here? Let me know :)

Yeah, that would be great.

But I think instead of resolving 150 conflicts for versions, it would be more effective to re-compile the dependencies. You could remove the yarn.lock before merging it in and re-compile afterwards.

andrewtavis commented 17 hours ago

Ah ya, 100% @to-sta :) I don't deal with yarn.lock conflicts. Always just swap in the most recent version of things and recompile 😊