activist-org / activist

An open-source activism platform
https://activist.org
GNU Affero General Public License v3.0
209 stars 173 forks source link

Command Palette with Headless UI and minor UX improvements #922

Closed mattburnett-repo closed 2 days ago

mattburnett-repo commented 4 days ago

Contributor checklist


Description

This PR builds on the Command Palette functionality already merged with the main repo.

This version of the component serves as a good starting point for further development of the Command Palette functionality.

Related issue

No known related and currently-open issue.

github-actions[bot] commented 4 days ago

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

netlify[bot] commented 4 days ago

Deploy Preview for activist-org ready!

Name Link
Latest commit a0fc0308bbb6acdf40584446fb4e8eb8460d6a22
Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6686fc06ec6d5b00088a3c20
Deploy Preview https://deploy-preview-922--activist-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrewtavis commented 4 days ago

Hey @mattburnett-repo 👋 There were a lot of changes in how modals work that came through in #881, and because of this we have some conflicts with the new changes :) Do you want to do a call to check these, or would you want to check them first?

mattburnett-repo commented 4 days ago

Hey @andrewtavis I sent you a message over Element about the conflicts. Probably best for us to do a vid conf to sort the conflicts out. Plus, I'd like to get up to speed on what the modal changes are.

andrewtavis commented 4 days ago

Sure thing, @mattburnett-repo! Looking forward :)

andrewtavis commented 3 days ago

Taking a look at this with @mattburnett-repo right now :) We've closed out the merge conflicts from #881, but as of now both methods of opening and closing the modal are included in the script tag. We should check specifically for if we need to emit the close anymore, which maybe we do need to as this could be specifically targeting ModalBase :)