Modals still open and can't be closed if we navigate away while they're open and then back

[andrewtavis]

Terms

• [X] I have searched all open bug reports
• [X] I agree to follow activist's Code of Conduct

Behavior

Something that came up during the recent testing of the command palette was the realization that when we navigate away while they're open, then if we come back they can't be closed (thus breaking the entire UI). Steps to reproduce this are:

• Go to a page where a modal works, say /home
• Click on the activist logo to go to the landing page
• With the back button of the browser, navigate back to /home
• Open the command palette with command or control k
• Navigate back to the landing page by using the forward button (do not close the command palette)
• Navigate back to the /home page using the back button

After the above steps, the command palette will still be open, and further all functionality to close it will also not function. The X to close won't work, and clicking outside the modal will also not close it.

Would be great if we look into this!

[andrewtavis]

Hey @mattburnett-repo 👋 Would this be something you'd be interested in looking into?

[andrewtavis]

Let me know if more explanation on how to reproduce would be helpful! :)

[mattburnett-repo]

@andrewtavis I'll get on this. Go ahead and assign it to me.

Is the behavior in this issue unique to command palette, or does it happen with other modals?

[andrewtavis]

Hey @mattburnett-repo 👋 Thanks for jumping in to help here! My assumption would be that this is for all modals given they're all using the same store, but I didn't test others :)