feature(settings): add TLS

actix / actix-extras

A collection of additional crates supporting the actix and actix-web frameworks.

https://actix.rs

Apache License 2.0

787 stars 206 forks source link

feature(settings): add TLS #380

Closed 0rangeFox closed 3 months ago

0rangeFox commented 10 months ago

PR Type

Feature

PR Checklist

[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] A changelog entry has been made for the appropriate packages.
[x] Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Added the logic to get the TLS option working, and separated this component as feature tls.

0rangeFox commented 10 months ago

The doc test workflow is prone to fail due to missing certificates on the TLS example.

0rangeFox commented 10 months ago

Did I miss something while moving the OpenSSL steps from the actix-web workflow to this one? It's because from what I can see it still gives an error on the OpenSSL side.

robjtede commented 10 months ago

sigh... windows and openssl are such great friends... lemme check it out today

robjtede commented 5 months ago

Can the feature be renamed to openssl please so we can add rustls later.