actix / actix-extras

A collection of additional crates supporting the actix and actix-web frameworks.
https://actix.rs
Apache License 2.0
760 stars 191 forks source link

chore: update futures & futures-core to 0.3.30 across workspace #407

Closed zopieux closed 6 months ago

zopieux commented 6 months ago

PR Type

Other

PR Checklist

Overview

The ancient futures & futures-core versions currently pinned are causing obscure issues with e.g. Identity (in actix-identity) not being recognized anymore by just adding the futures crate (any version) in a project that also depends on actix-identity. Bumping futures version in actix-* fixes it.

robjtede commented 6 months ago

Thank you for the report and contribution.

Increasing these version requirements is rarely the true solution to problems such as what you're describing. I've aligned the requirements to ^0.3.17 but without a reproduction case I don't want to accept this PR.