search

actix / actix-web

Actix Web is a powerful, pragmatic, and extremely fast web framework for Rust.
https://actix.rs
Apache License 2.0
21.6k stars 1.67k forks source link

CSRF middleware for actix-web 1.0 #1185

Closed tommket closed 4 years ago

tommket commented 4 years ago

Where is the CSRF middleware for actix-web 1.0?

fafhrd91 commented 4 years ago

It wasn’t ported.

tommket commented 4 years ago

Is there any chance of https://github.com/SnoozeTime/actix-csrf getting some more support?

0xpr03 commented 4 years ago

@tommket what do you mean with support ? You can ask the author https://github.com/SnoozeTime if you're missing any features.

tommket commented 4 years ago

@0xpr03 I mean if it could become one of the other actix-... crates the same way the other middleware crates got created and continually maintained? There is an open issue https://github.com/SnoozeTime/actix-csrf/issues/1 where the author recently stated that he is waiting for someone sufficiently knowledgeable in actix and rust to review his code, before he is willing to release it as a crate. So pls anyone contributing to actix-... code and willing to review it would be welcome.

0xpr03 commented 4 years ago

Just as a note: I'm using the SameSite attribute as CSRF prevention.

tommket commented 4 years ago

@0xpr03 Yes I read about that too, but that does not help with subdomains.

fafhrd91 commented 4 years ago

i guess there is nothing to do in actix-web repo

0xpr03 commented 4 years ago

@tommket I'd recommend to ask in the actix Gitter chat and see if you'll find some people to help you with this project.

JohnWaltonProjects commented 4 years ago

Does anyone know why it was removed?